feat(SelectTree): add IsReset parameter #4863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThe PR adds a new IsReset parameter to the SelectTree component and propagates it to the underlying TreeView component. This parameter controls whether loaded data should be reset on page refresh. Class diagram for SelectTree component with IsReset parameterclassDiagram
class SelectTree {
+bool IsEditable
+bool IsReset
+IStringLocalizer~SelectTree~ Localizer
}
note for SelectTree "IsReset is a new parameter added to control data reset on page refresh."
Class diagram for TreeView component with IsReset parameterclassDiagram
class TreeView {
+TValue Items
+bool IsReset
+bool ShowIcon
+OnTreeItemClick
+ModelEqualityComparer
+CustomKeyAttribute
+OnExpandNodeAsync
}
note for TreeView "IsReset parameter is propagated from SelectTree to TreeView."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @tiansfather. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @tiansfather - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template with details about the bug being fixed, risk assessment, and verification steps. This will help reviewers understand the context and impact of the change.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4863 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 623 623
Lines 27831 27832 +1
Branches 3982 3982
=========================================
+ Hits 27831 27832 +1 ☔ View full report in Codecov by Sentry. |
ArgoZhang
changed the title
ArgoZhang
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add IsReset parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #4867
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: